Fix selecting AnimationTree node not changing bottom panel #93659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
requested changes
Jun 30, 2024
There was a problem hiding this comment.
This should never be merged.
Because AnimationTree has been able to have its own AnimationLibrary since 4.2, it is necessary to use AnimationPlayerEditor to edit it.
So what needs to be fixed is the display priority issue, not the disabling of AnimationTree's use of AnimationPlayerEditor.
Although #93632 approach is more right than this PR, but the problem is how to define the order. Maybe a new API for defining order is needed somewhere.
|
Yeah this makes it impossible to editor AnimationTree's animations, because the editor does not receive the selected tree. |
|
Closing then as this is not the correct approach. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93455
Changed AnimationPlayerEditorPlugin to handle only AnimationPlayer.